| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Robert Treat <rob(at)xzilla(dot)net>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: DOC: fixes multiple errors in alter table doc |
| Date: | 2026-03-02 09:22:29 |
| Message-ID: | 86974902-199B-413E-B4DA-9A484AB3A119@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Mar 2, 2026, at 17:04, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> On Thu, Jan 22, 2026 at 6:38 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>> PFA v3: Rebased, and added reviewer and discussion information.
>
> LGTM.
>
> Should we apply the same change to the ALTER FOREIGN TABLE docs as well?
Sure, I can make the change.
>
> While reviewing that section, I noticed that ADD COLUMN IF NOT EXISTS appears
> to work for ALTER FOREIGN TABLE, but it isn't documented. I'm not sure why
> it was left out, but perhaps we should document it and add a regression test in
> a separate patch?
>
I will verify that, then update the doc and regression test accordingly.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Steven Niu | 2026-03-02 09:32:30 | Re: Refactor handling of "-only" options in pg_dump, pg_restore |
| Previous Message | Chao Li | 2026-03-02 09:17:40 | astreamer_lz4: fix bug of output pointer advancement in decompressor |