| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
| Cc: | jian(dot)universality(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: IGNORE/RESPECT NULLS can be specified for (prokind == 'f'). |
| Date: | 2026-06-17 01:44:33 |
| Message-ID: | 8BACA715-B9B6-479D-9153-C05F05482664@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Jun 17, 2026, at 09:17, Tatsuo Ishii <ishii(at)postgresql(dot)org> wrote:
>
>>>> To fix this, ParseFuncOrColumn() now checks whether other than window
>>>> functions are used with the null treatment clause. If so, error out.
>>>>
>>>> Also remove the unnecessary test for "aggregate functions do not
>>>> accept RESPECT/IGNORE NULLS" because it is now checked in the
>>>> early-stage new check. The window regression test expected file is
>>>> changed accordingly.
>>>
>>> I'm going to push the patch today if there's no objection.
>>
>> The code looks good to me, and the commit message is clear and well-written.
>
> Thank you for the review!
> I have pushed the patch to master branch.
> https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=4e5920e6de87dc1ed761d2a898b7786c50c11db2
> --
> Tatsuo Ishii
> SRA OSS K.K.
> English: http://www.sraoss.co.jp/index_en/
> Japanese:http://www.sraoss.co.jp
>
Hi Tatsuo-san,
Sorry for jumping in. I didn’t review the patch, but while browsing recent commits, I noticed that this commit has a small issue: the errmsg should start with a lowercase character, according to the error style guide [1]:
```
Primary error messages: Do not capitalize the first letter. Do not end a message with a period. Do not even think about ending a message with an exclamation point.
```
The attached diff is a quick fix that changes “Only” to “only” and updates the expected output accordingly.
[1] https://www.postgresql.org/docs/current/error-style-guide.html
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| Attachment | Content-Type | Size |
|---|---|---|
| nocfbot-fix-errmsg.diff | application/octet-stream | 1.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2026-06-17 01:53:40 | Re: Support EXCEPT for TABLES IN SCHEMA publications |
| Previous Message | Masahiko Sawada | 2026-06-17 01:20:17 | Re: Fix race condition in pg_get_publication_tables with concurrent DROP TABLE |