| From: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
|---|---|
| To: | jian(dot)universality(at)gmail(dot)com |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: IGNORE/RESPECT NULLS can be specified for (prokind == 'f'). |
| Date: | 2026-06-17 01:17:14 |
| Message-ID: | 20260617.101714.902726172425852267.ishii@postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>> > To fix this, ParseFuncOrColumn() now checks whether other than window
>> > functions are used with the null treatment clause. If so, error out.
>> >
>> > Also remove the unnecessary test for "aggregate functions do not
>> > accept RESPECT/IGNORE NULLS" because it is now checked in the
>> > early-stage new check. The window regression test expected file is
>> > changed accordingly.
>>
>> I'm going to push the patch today if there's no objection.
>
> The code looks good to me, and the commit message is clear and well-written.
Thank you for the review!
I have pushed the patch to master branch.
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=4e5920e6de87dc1ed761d2a898b7786c50c11db2
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2026-06-17 01:20:17 | Re: Fix race condition in pg_get_publication_tables with concurrent DROP TABLE |
| Previous Message | Sergey Tatarintsev | 2026-06-17 00:53:12 | Re: 004_timeline_switch TAP test may fail |