| From: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
|---|---|
| To: | li(dot)evan(dot)chao(at)gmail(dot)com |
| Cc: | jian(dot)universality(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: IGNORE/RESPECT NULLS can be specified for (prokind == 'f'). |
| Date: | 2026-06-17 03:58:05 |
| Message-ID: | 20260617.125805.1854568406469657411.ishii@postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Chao,
> Hi Tatsuo-san,
>
> Sorry for jumping in. I didn’t review the patch, but while browsing recent commits, I noticed that this commit has a small issue: the errmsg should start with a lowercase character, according to the error style guide [1]:
> ```
> Primary error messages: Do not capitalize the first letter. Do not end a message with a period. Do not even think about ending a message with an exclamation point.
> ```
>
> The attached diff is a quick fix that changes “Only” to “only” and updates the expected output accordingly.
>
> [1] https://www.postgresql.org/docs/current/error-style-guide.html
You are right. I don't know why I forgot the rule. Patch pushed.
Thank you!
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Peter Smith | 2026-06-17 03:38:10 | Re: Support EXCEPT for TABLES IN SCHEMA publications |