Re: pgsql: Move interrupt-handling code into subroutines.

From: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
To: Robert Haas <rhaas(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Move interrupt-handling code into subroutines.
Date: 2019-12-17 18:43:39
Message-ID: 8736diaj98.fsf@news-spur.riddles.org.uk
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

>>>>> "Robert" == Robert Haas <rhaas(at)postgresql(dot)org> writes:

Robert> Move interrupt-handling code into subroutines.

This is eliciting compiler warnings from gcc, which apparently doesn't
count "static void foo();" as being a prototype (quite reasonably, since
it's not).

Needs this fix (in autovacuum.c and checkpointer.c):

-static void AutoVacLauncherShutdown() pg_attribute_noreturn();
+static void AutoVacLauncherShutdown(void) pg_attribute_noreturn();

-static void HandleCheckpointerInterrupts();
+static void HandleCheckpointerInterrupts(void);

--
Andrew (irc:RhodiumToad)

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2019-12-17 18:59:17 pgsql: Add missing "void" to prototypes.
Previous Message Robert Haas 2019-12-17 18:18:22 pgsql: Partially deduplicate interrupt handling for background processe