pgsql: Partially deduplicate interrupt handling for background processe

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Partially deduplicate interrupt handling for background processe
Date: 2019-12-17 18:18:22
Message-ID: E1ihHQM-0005wd-J6@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Partially deduplicate interrupt handling for background processes.

Where possible, share signal handler code and main loop interrupt
checking. This saves quite a bit of code and should simplify
maintenance, too.

This commit intends not to change the way anything works, even
though that might allow more code to be unified. It does unify
a bunch of individual variables into a ShutdownRequestPending
flag that has is now used by a bunch of different process types,
though.

Patch by me, reviewed by Andres Freund and Daniel Gustafsson.

Discussion: http://postgr.es/m/CA+TgmoZwDk=BguVDVa+qdA6SBKef=PKbaKDQALTC_9qoz1mJqg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7dbfea3c455e83a77213a92b9dfdc1c0577441ea

Modified Files
--------------
src/backend/postmaster/Makefile | 1 +
src/backend/postmaster/autovacuum.c | 29 +++-----
src/backend/postmaster/bgworker.c | 25 +------
src/backend/postmaster/bgwriter.c | 93 ++-----------------------
src/backend/postmaster/checkpointer.c | 60 ++--------------
src/backend/postmaster/interrupt.c | 108 +++++++++++++++++++++++++++++
src/backend/postmaster/pgarch.c | 29 ++------
src/backend/postmaster/pgstat.c | 28 ++------
src/backend/postmaster/startup.c | 34 +--------
src/backend/postmaster/walwriter.c | 84 ++--------------------
src/backend/replication/logical/launcher.c | 3 +-
src/backend/replication/logical/worker.c | 3 +-
src/backend/replication/walreceiver.c | 31 +--------
src/backend/replication/walsender.c | 4 +-
src/backend/tcop/postgres.c | 22 +-----
src/backend/utils/init/globals.c | 1 -
src/include/miscadmin.h | 3 -
src/include/postmaster/interrupt.h | 32 +++++++++
18 files changed, 191 insertions(+), 399 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Gierth 2019-12-17 18:43:39 Re: pgsql: Move interrupt-handling code into subroutines.
Previous Message Robert Haas 2019-12-17 18:09:00 pgsql: Use PostgresSigHupHandler in more places.