From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
Cc: | pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: pgsql: Move interrupt-handling code into subroutines. |
Date: | 2019-12-17 18:59:21 |
Message-ID: | CA+TgmobdS2Cog5UA=DP7VNmUjXNMGeAFQcxQqHNTpbLv4P=L2A@mail.gmail.com |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On Tue, Dec 17, 2019 at 1:43 PM Andrew Gierth
<andrew(at)tao11(dot)riddles(dot)org(dot)uk> wrote:
> >>>>> "Robert" == Robert Haas <rhaas(at)postgresql(dot)org> writes:
>
> Robert> Move interrupt-handling code into subroutines.
>
> This is eliciting compiler warnings from gcc, which apparently doesn't
> count "static void foo();" as being a prototype (quite reasonably, since
> it's not).
>
> Needs this fix (in autovacuum.c and checkpointer.c):
>
> -static void AutoVacLauncherShutdown() pg_attribute_noreturn();
> +static void AutoVacLauncherShutdown(void) pg_attribute_noreturn();
>
> -static void HandleCheckpointerInterrupts();
> +static void HandleCheckpointerInterrupts(void);
Sorry about that. Fix pushed.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2019-12-17 19:09:46 | pgsql: simplehash: Allow use of simplehash without MemoryContext. |
Previous Message | Robert Haas | 2019-12-17 18:59:17 | pgsql: Add missing "void" to prototypes. |