| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org, Rémi Zara <remi_zara(at)mac(dot)com>, Stefan Huehner <stefan(at)huehner(dot)org> |
| Subject: | Re: Alpha4 release blockers (was Re: wrapping up this CommitFest) |
| Date: | 2011-03-07 17:40:55 |
| Message-ID: | 8195.1299519655@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> On sn, 2011-03-06 at 12:16 -0500, Tom Lane wrote:
>> I'm still not thrilled with the plan of sprinkling the code with
>> random fmgr_info_collation() calls to make up for the lack of a sane
>> default. IMO, that *is* a default, just a badly implemented one.
> We have touched upon this point several times during the development of
> this patch. The main problem is that you need to distinguish no
> collation from the default collation, so they can't both be OID zero.
Fair enough, but throwing in fmgr_info_collation(DEFAULT_COLLATION)
anytime we have a problem seems to me to introduce the exact same issue.
Who's to say that that's really the appropriate value to use?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Fetter | 2011-03-07 17:51:06 | Re: [HACKERS] Sync rep doc corrections |
| Previous Message | Dimitri Fontaine | 2011-03-07 17:35:27 | Re: Mark deprecated operators as such in their comments? |