| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org, Rémi Zara <remi_zara(at)mac(dot)com>, Stefan Huehner <stefan(at)huehner(dot)org> |
| Subject: | Re: Alpha4 release blockers (was Re: wrapping up this CommitFest) |
| Date: | 2011-03-08 22:25:08 |
| Message-ID: | 1299623108.19938.7.camel@vanquo.pezone.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On mån, 2011-03-07 at 12:40 -0500, Tom Lane wrote:
> Fair enough, but throwing in fmgr_info_collation(DEFAULT_COLLATION)
> anytime we have a problem seems to me to introduce the exact same
> issue. Who's to say that that's really the appropriate value to use?
It normally isn't the appropriate value to use. It's only appropriate
if either that particular part of the code doesn't support collations
yet or it's dealing with some hardcoded catalog lookups or some similar
case. In most other cases you should be getting the collation passed in
from somewhere, and if you aren't there is probably some work to do to
get it there. That's at least sort of the experience from developing
this.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-03-08 22:43:12 | Re: Alpha4 release blockers (was Re: wrapping up this CommitFest) |
| Previous Message | Peter Eisentraut | 2011-03-08 22:04:26 | Re: Parallel make problem with git master |