| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org, Rémi Zara <remi_zara(at)mac(dot)com>, Stefan Huehner <stefan(at)huehner(dot)org> |
| Subject: | Re: Alpha4 release blockers (was Re: wrapping up this CommitFest) |
| Date: | 2011-03-07 17:25:46 |
| Message-ID: | 1299518746.874.6.camel@vanquo.pezone.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On sön, 2011-03-06 at 12:16 -0500, Tom Lane wrote:
> I'm still not thrilled with the plan of sprinkling the code with
> random fmgr_info_collation() calls to make up for the lack of a sane
> default. IMO, that *is* a default, just a badly implemented one.
We have touched upon this point several times during the development of
this patch. The main problem is that you need to distinguish no
collation from the default collation, so they can't both be OID zero.
Another problem is that if you assume OID zero means default, finding
bugs in the expression tree analysis would be really hard. It would be
like saying, oh, we have type OID zero, let's make it text and proceed.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dimitri Fontaine | 2011-03-07 17:35:27 | Re: Mark deprecated operators as such in their comments? |
| Previous Message | Thom Brown | 2011-03-07 17:23:17 | Re: Sync rep doc corrections |