| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | David Fetter <david(at)fetter(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Increase psql's password buffer size |
| Date: | 2020-01-22 02:01:02 |
| Message-ID: | 7c4d5916-afd5-df1a-f7d0-9817149efa50@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020/01/22 0:12, Bruce Momjian wrote:
> On Tue, Jan 21, 2020 at 02:42:07PM +0900, Fujii Masao wrote:
>> I have no strong opinion about the maximum length of password,
>> for now. But IMO it's worth committing that 0001 patch as the first step
>> for this problem.
>>
>> Also IMO the more problematic thing is that psql silently truncates
>> the password specified in the prompt into 99B if its length is
>> more than 99B. I think that psql should emit a warning in this case
>> so that users can notice that.
>
> I think we should be using a macro to define the maximum length, rather
> than have 100 used in various places.
+1 as the first step for this issue. The patch that I mentioned
upthread actually does that.
Regards,
--
Fujii Masao
NTT DATA CORPORATION
Advanced Platform Technology Group
Research and Development Headquarters
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2020-01-22 02:03:42 | Re: Increase psql's password buffer size |
| Previous Message | Tatsuro Yamada | 2020-01-22 01:46:11 | Re: progress report for ANALYZE |