| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | David Fetter <david(at)fetter(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Increase psql's password buffer size |
| Date: | 2020-01-21 15:12:52 |
| Message-ID: | 20200121151252.GC7084@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 21, 2020 at 02:42:07PM +0900, Fujii Masao wrote:
> I have no strong opinion about the maximum length of password,
> for now. But IMO it's worth committing that 0001 patch as the first step
> for this problem.
>
> Also IMO the more problematic thing is that psql silently truncates
> the password specified in the prompt into 99B if its length is
> more than 99B. I think that psql should emit a warning in this case
> so that users can notice that.
I think we should be using a macro to define the maximum length, rather
than have 100 used in various places.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Fetter | 2020-01-21 15:19:13 | Re: Increase psql's password buffer size |
| Previous Message | James Coleman | 2020-01-21 15:03:31 | Re: [PATCH] Incremental sort (was: PoC: Partial sort) |