Re: Increase psql's password buffer size

On 2020/01/22 11:01, Fujii Masao wrote:
>
>
> On 2020/01/22 0:12, Bruce Momjian wrote:
>> On Tue, Jan 21, 2020 at 02:42:07PM +0900, Fujii Masao wrote:
>>> I have no strong opinion about the maximum length of password,
>>> for now. But IMO it's worth committing that 0001 patch as the first step
>>> for this problem.
>>>
>>> Also IMO the more problematic thing is that psql silently truncates
>>> the password specified in the prompt into 99B if its length is
>>> more than 99B. I think that psql should emit a warning in this case
>>> so that users can notice that.
>>
>> I think we should be using a macro to define the maximum length, rather
>> than have 100 used in various places.
>
> +1 as the first step for this issue. The patch that I mentioned
> upthread actually does that.

Attached is the patch that Nathan proposed at [1] and I think that
it's worth applying. I'd like to add this to next CommitFest.
Thought?

[1] https://www.postgresql.org/message-id/09512C4F-8CB9-4021-B455-EF4C4F0D55A0@amazon.com

Regards,

--
Fujii Masao
NTT DATA CORPORATION
Advanced Platform Technology Group
Research and Development Headquarters