Re: Improve logging when using Huge Pages

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pryzby(at)telsasoft(dot)com
Cc: noriyoshi(dot)shinoda(at)hpe(dot)com, pgsql-hackers(at)postgresql(dot)org, rjuju123(at)gmail(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us
Subject: Re: Improve logging when using Huge Pages
Date: 2021-09-16 15:13:41
Message-ID: 7ad09915-d8b1-1bce-b962-7062e2cf346a@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2021/09/08 11:17, Kyotaro Horiguchi wrote:
> I don't dislike the message, but I'm not sure I like the message is
> too verbose, especially about it has DETAILS. It seems to me something
> like the following is sufficient, or I'd like see it even more concise.
>
> "fall back anonymous shared memory to non-huge pages: required %zu bytes for huge pages"
>
> If we emit an error message for other than mmap failure, it would be
> like the following.
>
> "fall back anonymous shared memory to non-huge pages: huge pages not available"

How about simpler message like "disabling huge pages" or
"disabling huge pages due to lack of huge pages available"?

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message gkokolatos 2021-09-16 15:17:15 Re: Teach pg_receivewal to use lz4 compression
Previous Message Fujii Masao 2021-09-16 15:12:39 Re: Improve logging when using Huge Pages