From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
---|---|
To: | masao(dot)fujii(at)oss(dot)nttdata(dot)com |
Cc: | pryzby(at)telsasoft(dot)com, noriyoshi(dot)shinoda(at)hpe(dot)com, pgsql-hackers(at)postgresql(dot)org, rjuju123(at)gmail(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us |
Subject: | Re: Improve logging when using Huge Pages |
Date: | 2021-09-17 04:14:30 |
Message-ID: | 20210917.131430.1276120422145591578.horikyota.ntt@gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
At Fri, 17 Sep 2021 00:13:41 +0900, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote in
>
>
> On 2021/09/08 11:17, Kyotaro Horiguchi wrote:
> > I don't dislike the message, but I'm not sure I like the message is
> > too verbose, especially about it has DETAILS. It seems to me something
> > like the following is sufficient, or I'd like see it even more
> > concise.
> > "fall back anonymous shared memory to non-huge pages: required %zu
> > bytes for huge pages"
> > If we emit an error message for other than mmap failure, it would be
> > like the following.
> > "fall back anonymous shared memory to non-huge pages: huge pages not
> > available"
>
> How about simpler message like "disabling huge pages" or
> "disabling huge pages due to lack of huge pages available"?
Honestly, I cannot have conficence on my wording, but "disabling huge
pages" souds like somthing that happens on the OS layer. "did not
use/gave up using huge pages for anounymous shared memory" might work
well, I'm not sure, though...
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2021-09-17 04:48:11 | Re: walsender timeout on logical replication set |
Previous Message | vignesh C | 2021-09-17 04:06:41 | Re: Column Filtering in Logical Replication |