| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Subject: | Re: Large writable variables |
| Date: | 2018-10-25 00:04:34 |
| Message-ID: | 79c80f75-7b14-1d88-e26b-f634991b8cfb@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 18/10/2018 21:31, Andres Freund wrote:
> On 2018-10-18 22:17:55 +0200, Peter Eisentraut wrote:
>> I'd perhaps change the signature
>>
>> #define unconstify(underlying_type, var)
>>
>> because the "var" doesn't actually have to be a variable.
>
> Hm, so expr, or what would you use?
done
>> Attached is my previous patch adapted to your macro.
>>
>> I'm tempted to get rid of the stuff in dfmgr.c and just let the "older
>> platforms" get the warning.
and done
> Yea, that works for me.
>
> Are you planning to apply this?
and done
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-10-25 00:47:51 | Re: Function to promote standby servers |
| Previous Message | David Rowley | 2018-10-25 00:00:08 | Re: Log timestamps at higher resolution |