Re: Function to promote standby servers

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>
Cc: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Function to promote standby servers
Date: 2018-10-25 00:47:51
Message-ID: 20181025004751.GA5902@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Oct 24, 2018 at 08:50:43AM +0900, Michael Paquier wrote:
> On Tue, Oct 23, 2018 at 09:42:16AM +0200, Laurenz Albe wrote:
> > No objections from me; on the contrary, I would like to thank you for
> > your effort here. I appreciate that you probably spent more time
> > tutoring me than it would have taken you to write this yourself.
>
> You're welcome. Happy that it helped.

And committed. I double-checked the code, and tweaked a bit the tests
so as the test using wait_mode = false is removed as it did not seem
worth the extra cycles. I also added a check on the return value of
pg_promote when using the wait mode. Another thing was that the
function needs to be parallel-restricted.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-10-25 01:10:20 Re: Log timestamps at higher resolution
Previous Message Peter Eisentraut 2018-10-25 00:04:34 Re: Large writable variables