Re: Large writable variables

From: Andres Freund <andres(at)anarazel(dot)de>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Subject: Re: Large writable variables
Date: 2018-10-18 20:31:13
Message-ID: 20181018203113.t455hsgihmx6gkg4@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2018-10-18 22:17:55 +0200, Peter Eisentraut wrote:
> I'd perhaps change the signature
>
> #define unconstify(underlying_type, var)
>
> because the "var" doesn't actually have to be a variable.

Hm, so expr, or what would you use?

> Attached is my previous patch adapted to your macro.
>
> I'm tempted to get rid of the stuff in dfmgr.c and just let the "older
> platforms" get the warning.

Yea, that works for me.

Are you planning to apply this?

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2018-10-18 20:44:08 Re: Making all nbtree entries unique by having heap TIDs participate in comparisons
Previous Message Andres Freund 2018-10-18 20:29:39 Re: Large writable variables