Re: pgindent run?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Mark Dilger <hornschnorter(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgindent run?
Date: 2017-11-28 20:47:17
Message-ID: 7825.1511902037@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Mark Dilger <hornschnorter(at)gmail(dot)com> writes:
> I have no objection, but if the community intends to keep everything
> indented per project standards, why is there no git hook to reject
> improperly indented code at commit time? I've suffered some pain
> trying to merge code pre-global-indent-run into a branch
> post-global-indent-run and would rather this not keep happening.

I think that'd be taking it too far, especially given that the dependency
on a typedefs list means that the git hook might have a different idea
of what's correctly indented than the committer does. It'd be very hard
to debug such discrepancies and figure out what would satisfy the hook.

In the end we're trying to minimize the net amount of pain involved.
I doubt that mechanized enforcement would fall at the global minimum.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-11-28 20:50:13 Re: [HACKERS] Patch: Add --no-comments to skip COMMENTs with pg_dump
Previous Message Tom Lane 2017-11-28 20:40:46 Re: Updated macOS start scripts