Re: pgindent run?

From: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Mark Dilger <hornschnorter(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgindent run?
Date: 2017-11-28 21:23:11
Message-ID: CAEepm=0tC8jiaG-6whG1H8Sry6DFOVO49-f2keD_5rfpUdYqfA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 29, 2017 at 9:47 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Mark Dilger <hornschnorter(at)gmail(dot)com> writes:
>> I have no objection, but if the community intends to keep everything
>> indented per project standards, why is there no git hook to reject
>> improperly indented code at commit time? I've suffered some pain
>> trying to merge code pre-global-indent-run into a branch
>> post-global-indent-run and would rather this not keep happening.
>
> I think that'd be taking it too far, especially given that the dependency
> on a typedefs list means that the git hook might have a different idea
> of what's correctly indented than the committer does. It'd be very hard
> to debug such discrepancies and figure out what would satisfy the hook.
>
> In the end we're trying to minimize the net amount of pain involved.
> I doubt that mechanized enforcement would fall at the global minimum.

Is there no way to get reasonable indentation that doesn't depend on
that typedefs list?

--
Thomas Munro
http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-11-28 21:32:52 Re: [HACKERS] postgres_fdw super user checks
Previous Message Peter Eisentraut 2017-11-28 21:22:02 Re: Updated macOS start scripts