Re: [HACKERS] Patch: Add --no-comments to skip COMMENTs with pg_dump

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Fabrízio Mello <fabriziomello(at)gmail(dot)com>
Cc: Robins Tharakan <tharakan(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, David Fetter <david(at)fetter(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Subject: Re: [HACKERS] Patch: Add --no-comments to skip COMMENTs with pg_dump
Date: 2017-11-28 20:50:13
Message-ID: CA+Tgmoa+fsCGsKDKq1w+mwsLxixpUC7G7zZX27UGiG6Oabj+BA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Aug 7, 2017 at 11:14 AM, Fabrízio de Royes Mello
<fabriziomello(at)gmail(dot)com> wrote:
> I also test against all current supported versions (9.2 ... 9.6) and didn't
> find any issue.
>
> Changed status to "ready for commiter".

On a very fast read this patch looks OK to me, but I'm a bit concerned
about whether we have consensus for it. By my count the vote is 6-3
in favor of proceeding.

+1: Robins Tharakan, Stephen Frost, David Fetter, Fabrizio Mello,
Michael Paquier, Robert Haas
-1: David G. Johnston, Tom Lane, Simon Riggs

I guess that's probably sufficient to go forward, but does anyone wish
to dispute my characterization of their vote or the vote tally in
general? Would anyone else like to cast a vote?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-11-28 20:54:11 Re: [HACKERS] postgres_fdw super user checks
Previous Message Tom Lane 2017-11-28 20:47:17 Re: pgindent run?