Re: pg_regress help output

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_regress help output
Date: 2017-10-11 02:06:38
Message-ID: 7683.1507687598@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Joe Conway <mail(at)joeconway(dot)com> writes:
> I have been annoyed at least twice now by the lack of pg_regress command
> line help output for the "--bindir=<path>" option. In passing I noted
> that there was no output for "--help" or "--version" options either.

> Any objections to the attached?

+1 for documenting it, but the phrasing seems a bit awkward:

! printf(_(" --bindir=BINPATH use BINPATH for programs that are run;\n"));
! printf(_(" if BINPATH empty, use PATH from the environment\n"));

Maybe just "if empty, use PATH ..." ?

Also, why is the patch apparently changing whitespace in all the help
lines? Seems like that will create a lot of make-work for translators.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2017-10-11 02:25:46 Re: [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple
Previous Message marko 2017-10-11 02:00:58 BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much