Re: pg_regress help output

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Joe Conway <mail(at)joeconway(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_regress help output
Date: 2017-10-11 04:03:06
Message-ID: 20171011040306.jogniuk5fgzbo7ci@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Joe Conway <mail(at)joeconway(dot)com> writes:
> > I have been annoyed at least twice now by the lack of pg_regress command
> > line help output for the "--bindir=<path>" option. In passing I noted
> > that there was no output for "--help" or "--version" options either.
>
> > Any objections to the attached?
>
> +1 for documenting it, but the phrasing seems a bit awkward:
>
> ! printf(_(" --bindir=BINPATH use BINPATH for programs that are run;\n"));
> ! printf(_(" if BINPATH empty, use PATH from the environment\n"));
>
> Maybe just "if empty, use PATH ..." ?
>
> Also, why is the patch apparently changing whitespace in all the help
> lines? Seems like that will create a lot of make-work for translators.

I think we don't have translations for pg_regress.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2017-10-11 06:30:23 Re: How does postgres store the join predicate for a relation in a given query
Previous Message Jeremy Schneider 2017-10-11 03:44:39 Re: show precise repos version for dev builds?