| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Aleksander Alekseev <aleksander(at)tigerdata(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Arseniy Mukhin <arseniy(dot)mukhin(dot)dev(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us> |
| Subject: | Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments |
| Date: | 2025-12-11 21:43:31 |
| Message-ID: | aTs7A4lbcm0ThXaO@nathan |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Oct 28, 2025 at 08:36:33AM +0800, Chao Li wrote:
> On Oct 28, 2025, at 07:35, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>> On Mon, Oct 27, 2025 at 09:55:38AM -0500, Nathan Bossart wrote:
>>> /*
>>> * DISABLE_LEADER_PARTICIPATION disables the leader's participation in
>>> * parallel index builds. This may be useful as a debugging aid.
>>> -#undef DISABLE_LEADER_PARTICIPATION
>>> + *#undef DISABLE_LEADER_PARTICIPATION
>>> */
>>>
>>> IMHO we should either remove this line or move it out of the comment.
>>> AFAICT we ordinarily don't #undef debugging stuff like this, presumably so
>>> you can change it with compile flags.
>>
>> I would put this one on a separate line, outside the comment. It's
>> minor, still we use this style in pg_config_manual.h. See around
>> REALLOCATE_BITMAPSETS.
>
> +1
Here's a patch for this. I also changed the #undefs to #defines.
--
nathan
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-fix-some-commented-undefs.patch | text/plain | 2.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2025-12-11 21:48:27 | Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments |
| Previous Message | Álvaro Herrera | 2025-12-11 21:36:55 | Re: Issues with ON CONFLICT UPDATE and REINDEX CONCURRENTLY |