Re: file_fdw: Fix ANALYZE crashes with DEFAULT markers

From: Ayoub Kazar <ayoub(dot)kazar(at)data-bene(dot)io>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Cc: Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: file_fdw: Fix ANALYZE crashes with DEFAULT markers
Date: 2026-11-05 10:55:31
Message-ID: 714a074f-c228-44c1-8167-24d08af5d242@data-bene.io
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 05/11/2026 09:54, Fujii Masao wrote:
> On Thu, Nov 5, 2026 at 4:50 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>> So, if we use ResetPerTupleExprContext(estate), then
>> MemoryContextSwitchTo(econtext->ecxt_per_tuple_memory); should be
>> changed accordingly. I think Ayoub commented the same thing.
> Agreed. I've updated the patch to use ResetPerTupleExprContext(estate)
> and MemoryContextSwitchTo(GetPerTupleMemoryContext(estate)). Attached.
Looks good.

Regards,
Ayoub Kazar

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Chao Li 2026-11-05 11:09:14 Re: file_fdw: Fix ANALYZE crashes with DEFAULT markers
Previous Message Ilia Evdokimov 2026-11-05 10:38:26 Re: Fold NOT IN / <> ALL expressions containing NULL to FALSE