Re: file_fdw: Fix ANALYZE crashes with DEFAULT markers

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Ayoub Kazar <ayoub(dot)kazar(at)data-bene(dot)io>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: file_fdw: Fix ANALYZE crashes with DEFAULT markers
Date: 2026-11-05 11:09:14
Message-ID: 61E107C5-4E27-46B9-84D4-ECDA7C63A381@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Nov 5, 2026, at 18:55, Ayoub Kazar <ayoub(dot)kazar(at)data-bene(dot)io> wrote:
>
>
> On 05/11/2026 09:54, Fujii Masao wrote:
>> On Thu, Nov 5, 2026 at 4:50 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>>> So, if we use ResetPerTupleExprContext(estate), then MemoryContextSwitchTo(econtext->ecxt_per_tuple_memory); should be changed accordingly. I think Ayoub commented the same thing.
>> Agreed. I've updated the patch to use ResetPerTupleExprContext(estate) and MemoryContextSwitchTo(GetPerTupleMemoryContext(estate)). Attached.
> Looks good.

+1

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Previous Message Ayoub Kazar 2026-11-05 10:55:31 Re: file_fdw: Fix ANALYZE crashes with DEFAULT markers