| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Ayoub Kazar <ayoub(dot)kazar(at)data-bene(dot)io> |
| Subject: | Re: file_fdw: Fix ANALYZE crashes with DEFAULT markers |
| Date: | 2026-11-05 08:54:52 |
| Message-ID: | CAHGQGwEEMgw6yFaQ+7DY17+8yG1_Pm=U+M+kTtGFEDPWtPyDYg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 5, 2026 at 4:50 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> So, if we use ResetPerTupleExprContext(estate), then MemoryContextSwitchTo(econtext->ecxt_per_tuple_memory); should be changed accordingly. I think Ayoub commented the same thing.
Agreed. I've updated the patch to use ResetPerTupleExprContext(estate) and
MemoryContextSwitchTo(GetPerTupleMemoryContext(estate)). Attached.
Regards,
--
Fujii Masao
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-file_fdw-Fix-ANALYZE-crashes-with-DEFAULT-markers.patch | application/octet-stream | 4.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2026-11-05 09:03:10 | Re: Fix translation error in zh_CN.po for "parameter specified more than once" |
| Previous Message | shveta malik | 2026-11-05 08:54:20 | Re: Proposal: Conflict log history table for Logical Replication |