Re: pgsql: Revert online data checksum transitions

> On 16 Sep 2026, at 16:08, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
>
> On 16/09/2026 16:04, Daniel Gustafsson wrote:
>>> On 16 Sep 2026, at 14:58, Manuel Reyes Bravo <manuelreyesbravo(at)gmail(dot)com> wrote:
>>> The server itself is not at risk, since PG_CONTROL_VERSION was bumped
>>> and 19.0 refuses a beta3 data directory; it is only tools reading
>>> archived beta3 WAL that cannot tell the formats apart. But the revert
>>> of 0d3dba38c77 on this branch (01a80f06214) bumped the magic for the
>>> same reason, so it looks like this one should too.
>> Thanks for the report, will include when fixing.
>
> Also, the ControlFile->data_checksum_version_init is now never set.

This patch is as difficult to back out as it was to get in. I've been trying
to save a few small generic checksum bugfixes from the revert but that also
made it a lot more complicated. Will fix this one as well in the follow-up
fixup I have staged for later today.

--
Daniel Gustafsson