| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Tomas Vondra <tomas(at)vondra(dot)me>, Evgeniy Gorbanev <gorbanyoves(at)basealt(dot)ru>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: No error checking when reading from file using zstd in pg_dump |
| Date: | 2025-07-01 14:24:40 |
| Message-ID: | 69A4E455-94E6-4348-9007-D7CCBA0E2D40@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 26 Jun 2025, at 20:01, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
>> On 26 Jun 2025, at 15:33, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
>> So on the whole I prefer the "void" approach. I'm not dead
>> set on that though, it's just a niggling worry.
>
> I think the likelyhood of it being a problem in practice is pretty slim, but
> it's still a stronger argument than my "match an API we're still not aligned
> with". The attached v7 reverts back to void return.
In preparing for concluding this I've attached a v8 which is the patchset in v7
squashed into a single commit with an attempt at a commit message.
This version has been tested against v17 and v16 where it applies and passes
all tests (the latter isn't as assuring as it should be since there is a lack
of testcoverage).
--
Daniel Gustafsson
| Attachment | Content-Type | Size |
|---|---|---|
| v8-0001-pg_dump-Fix-compression-API-errorhandling.patch | application/octet-stream | 25.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melih Mutlu | 2025-07-01 14:28:30 | Re: Report replica identity in pg_publication_tables |
| Previous Message | Tom Lane | 2025-07-01 14:24:07 | Re: implicit casts from void* |