| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Tomas Vondra <tomas(at)vondra(dot)me>, Evgeniy Gorbanev <gorbanyoves(at)basealt(dot)ru>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: No error checking when reading from file using zstd in pg_dump |
| Date: | 2025-06-26 18:01:11 |
| Message-ID: | BBC4C1E4-EA6D-40E6-9FB9-1D917F2D1B20@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 26 Jun 2025, at 15:33, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> So on the whole I prefer the "void" approach. I'm not dead
> set on that though, it's just a niggling worry.
I think the likelyhood of it being a problem in practice is pretty slim, but
it's still a stronger argument than my "match an API we're still not aligned
with". The attached v7 reverts back to void return.
--
Daniel Gustafsson
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0001-Initial-patch-by-Tom-Lane.patch | application/octet-stream | 8.3 KB |
| v7-0002-pg_dump-compression-API-write_func.patch | application/octet-stream | 8.1 KB |
| v7-0003-pg_dump-compression-API-open_func.patch | application/octet-stream | 4.9 KB |
| v7-0004-pg_dump-compression-API-close_func.patch | application/octet-stream | 4.9 KB |
| v7-0005-pg_dump-compression-API-LZ4Stream_init.patch | application/octet-stream | 1.3 KB |
| v7-0006-pg_dump-compression-API-read_func-gets_func.patch | application/octet-stream | 7.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melanie Plageman | 2025-06-26 18:27:42 | Re: Simplify VM counters in vacuum code |
| Previous Message | Daniil Davydov | 2025-06-26 17:23:59 | Re: Bug with concurrent CREATE OR REPLACE (?) |