Re: proposal: possibility to read dumped table's name from file

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: John Naylor <john(dot)naylor(at)enterprisedb(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Erik Rijkers <er(at)xs4all(dot)nl>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Surafel Temesgen <surafel3000(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: proposal: possibility to read dumped table's name from file
Date: 2022-09-12 07:58:37
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> On 9 Sep 2022, at 11:00, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>> On Sep 9, 2022, at 5:53 PM, John Naylor <john(dot)naylor(at)enterprisedb(dot)com> wrote:
>> Note that the grammar has shift-reduce conflicts.

> Looks like the last rule for Filters should not be there.

Correct, fixed in the attached.

> I do wonder whether we should be using bison/flex here, seems like using a
> sledgehammer to crack a nut.

I don't the capabilities of the tool is all that interesting compared to the
long term maintainability and readability of the source code. Personally I
think a simple Bison/Flex parser is easier to read and reason about than the
corresponding written in C.

Daniel Gustafsson

Attachment Content-Type Size
v4-0001-Add-include-exclude-filtering-via-file-in-pg_dump.patch application/octet-stream 29.8 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Drouvot, Bertrand 2022-09-12 07:59:15 Re: Add tracking of backend memory allocated to pg_stat_activity
Previous Message Drouvot, Bertrand 2022-09-12 07:55:25 Re: Patch proposal: make use of regular expressions for the username in pg_hba.conf