| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Erik Rijkers <er(at)xs4all(dot)nl>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Surafel Temesgen <surafel3000(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: proposal: possibility to read dumped table's name from file |
| Date: | 2022-09-09 09:00:36 |
| Message-ID: | A9A76268-A5F7-4922-888E-E813CC9A9493@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Sep 9, 2022, at 5:53 PM, John Naylor <john(dot)naylor(at)enterprisedb(dot)com> wrote:
>
> On Thu, Sep 8, 2022 at 7:32 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>> [v3]
>
> Note that the grammar has shift-reduce conflicts. If you run a fairly
> recent Bison, you can show them like this:
>
> bison -Wno-deprecated -Wcounterexamples -d -o filterparse.c filterparse.y
>
> filterparse.y: warning: 2 shift/reduce conflicts [-Wconflicts-sr]
> filterparse.y: warning: shift/reduce conflict on token C_INCLUDE
> [-Wcounterexamples]
> Example: • C_INCLUDE include_object pattern
> Shift derivation
> Filters
> ↳ 3: Filter
> ↳ 4: • C_INCLUDE include_object pattern
> Reduce derivation
> Filters
> ↳ 2: Filters Filter
> ↳ 1: ε • ↳ 4: C_INCLUDE include_object pattern
> filterparse.y: warning: shift/reduce conflict on token C_EXCLUDE
> [-Wcounterexamples]
> Example: • C_EXCLUDE exclude_object pattern
> Shift derivation
> Filters
> ↳ 3: Filter
> ↳ 5: • C_EXCLUDE exclude_object pattern
> Reduce derivation
> Filters
> ↳ 2: Filters Filter
> ↳ 1: ε • ↳ 5: C_EXCLUDE exclude_object pattern
>
Looks like the last rule for Filters should not be there. I do wonder whether we should be using bison/flex here, seems like using a sledgehammer to crack a nut.
Cheers
Andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | houzj.fnst@fujitsu.com | 2022-09-09 09:01:07 | RE: Perform streaming logical transactions by background workers and parallel apply |
| Previous Message | Kyotaro Horiguchi | 2022-09-09 08:29:49 | Possible crash on standby |