| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, John Naylor <john(dot)naylor(at)enterprisedb(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Erik Rijkers <er(at)xs4all(dot)nl>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Surafel Temesgen <surafel3000(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: proposal: possibility to read dumped table's name from file |
| Date: | 2022-09-12 13:09:24 |
| Message-ID: | CAFj8pRDqvv6Cp7Q4X+g3e=9+zVcFSAe6w8KmxB1GDuKPgH=d6Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
po 12. 9. 2022 v 9:59 odesílatel Daniel Gustafsson <daniel(at)yesql(dot)se> napsal:
> > On 9 Sep 2022, at 11:00, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> >
> >> On Sep 9, 2022, at 5:53 PM, John Naylor <john(dot)naylor(at)enterprisedb(dot)com>
> wrote:
> >>
> >> Note that the grammar has shift-reduce conflicts.
>
> > Looks like the last rule for Filters should not be there.
>
> Correct, fixed in the attached.
>
> > I do wonder whether we should be using bison/flex here, seems like using
> a
> > sledgehammer to crack a nut.
>
>
> I don't the capabilities of the tool is all that interesting compared to
> the
> long term maintainability and readability of the source code. Personally I
> think a simple Bison/Flex parser is easier to read and reason about than
> the
> corresponding written in C.
>
When this work is done, then there is no reason to throw it. The parser in
bison/flex does the same work and it is true, so code is more readable.
Although for this case, a handy written parser was trivial too.
Regards
Pavel
>
> --
> Daniel Gustafsson https://vmware.com/
>
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2022-09-12 13:18:00 | Re: pg_stat_statements locking |
| Previous Message | Andrey Borodin | 2022-09-12 12:32:55 | Re: pg_stat_statements locking |