Re: PG15 beta1 fix pg_database view document

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>, "Shinoda, Noriyoshi (PN Japan FSIP)" <noriyoshi(dot)shinoda(at)hpe(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PG15 beta1 fix pg_database view document
Date: 2022-05-23 08:37:38
Message-ID: 662148e4-3e16-00d0-0ec7-4dee435b1d25@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 23.05.22 06:25, Michael Paquier wrote:
> Indeed. I have checked the rest of the catalog headers for any
> inconsistencies with the docs and what you have noticed here is the
> only one.

Committed. Thanks for checking.

> + <structfield>datlocprovider</structfield> <type>char</type>
> + </para>
> + <para>
> + Provider of the collation for this database:
> <literal>c</literal> = libc, <literal>i</literal> = icu
> + </para></entry>
>
> ICU needs to be upper-case if you are referring to the library name.
> Here, my guess is that you are referring to the value that can be
> passed down to the command? You could use lower-case terms like on
> the CREATE COLLATION page, but I would put these within a <literal>
> markup. Anyway, this formulation is incorrect.

This is presumably copied from pg_collation.collprovider, which uses the
same markup. If we want to improve it, they should be changed together.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2022-05-23 08:49:22 Re: psql now shows zero elapsed time after an error
Previous Message Chirag Karkera 2022-05-23 08:16:29 Use Dblink without column defination