Re: PG15 beta1 fix pg_database view document

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: "Shinoda, Noriyoshi (PN Japan FSIP)" <noriyoshi(dot)shinoda(at)hpe(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Subject: Re: PG15 beta1 fix pg_database view document
Date: 2022-05-23 04:25:15
Message-ID: YosMqzLVj8X7XH9X@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, May 23, 2022 at 02:00:18AM +0000, Shinoda, Noriyoshi (PN Japan FSIP) wrote:
> Thanks to all the developers. The attached patch updates the manual
> for the pg_database catalog.
> The current pg_database view definition is missing the
> datlocprovider column. The attached patch adds this column info.
> https://www.postgresql.org/docs/15/catalog-pg-database.html

Indeed. I have checked the rest of the catalog headers for any
inconsistencies with the docs and what you have noticed here is the
only one.

+ <structfield>datlocprovider</structfield> <type>char</type>
+ </para>
+ <para>
+ Provider of the collation for this database:
<literal>c</literal> = libc, <literal>i</literal> = icu
+ </para></entry>

ICU needs to be upper-case if you are referring to the library name.
Here, my guess is that you are referring to the value that can be
passed down to the command? You could use lower-case terms like on
the CREATE COLLATION page, but I would put these within a <literal>
markup. Anyway, this formulation is incorrect.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2022-05-23 04:31:12 Re: Handle infinite recursion in logical replication setup
Previous Message Shinoda, Noriyoshi (PN Japan FSIP) 2022-05-23 02:00:18 PG15 beta1 fix pg_database view document