Re: DROP OWNED BY

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> I'm working on the promised DROP OWNED patch, and just noticed that it
> needs modifications to the Grant/Revoke machinery that are too invasive
> to consider for 8.1; the problem is that ExecuteGrantStmt takes textual
> names for objects and grantees, and what I have from pg_shdepend are
> Oids.

So refactor the GrantStmt code into a layer that translates to OIDs and
another layer that does the work. The other way doesn't sound good to
me; it is prone to race conditions against someone doing a RENAME.

> Is anyone opposed to this idea? Further, is anyone opposed to the
> addition as a whole? I'm already a month and a half late with this
> part of the shdep patch, so if people think it's better to ship this
> release without it, so be it. (Of course I don't like that.)

I think we're rapidly approaching the point where we have to say "sorry,
that is too late for this release". DROP OWNED is really a new feature,
not an essential component of the ROLES patch, and we've already
stretched the no-new-features-after-freeze rule to the breaking point.
I'll take the full blame for that --- I should probably not have forced
in the ROLES patch so close to feature freeze when it was obviously not
finished --- but at some point we've got to say no.

regards, tom lane