Re: Further simplification of c.h's #include section

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Further simplification of c.h's #include section
Date: 2017-11-16 15:38:21
Message-ID: 6441.1510846701@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> writes:
> On 16 November 2017 at 15:52, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Anybody want to test this manually, or shall we just throw it into the
>> buildfarm and see what blows up?

> I don't have any cygwin around, but it compiles fine with the Visual
> Studios 2012 toolchain.

Thanks for testing! I pushed it after a little bit more cosmetic
rearrangement; in particular, I ended up deciding that the _WIN32_WINNT
business really ought to be before the system headers, even if we've
somehow got away without that all these years. The buildfarm will
soon tell us if I was right or not.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Aaron W. Swenson 2017-11-16 15:40:27 Re: pspg - psql pager
Previous Message Robert Haas 2017-11-16 15:36:40 Re: [HACKERS] Issues with logical replication