| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Further simplification of c.h's #include section |
| Date: | 2017-11-16 05:23:58 |
| Message-ID: | CAKJS1f_iaeztUHvpT53xd6Z_7O8brRF8=Z_70EnvWwpVU7cm9w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 16 November 2017 at 15:52, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Anybody want to test this manually, or shall we just throw it into the
> buildfarm and see what blows up?
I don't have any cygwin around, but it compiles fine with the Visual
Studios 2012 toolchain.
I do get some warnings:
(ClCompile target) ->
src/test/modules/test_session_hooks/test_session_hooks.c(112): warning
C4113: 'void (__cdecl *)()' differs in parameter lists from
'session_start_hook_type' [test_session_hooks.vcxproj]
src/test/modules/test_session_hooks/test_session_hooks.c(113): warning
C4113: 'void (__cdecl *)()' differs in parameter lists from
'session_end_hook_type' [test_session_hooks.vcxproj].
2 Warning(s)
But I imagine that was caused by 745948422c (also get the warnings without
your patch)
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2017-11-16 06:14:45 | Re: Further simplification of c.h's #include section |
| Previous Message | David Rowley | 2017-11-16 04:48:01 | Re: Treating work_mem as a shared resource (Was: Parallel Hash take II) |