Re: pg_resetwal prints new OldestXID in wrong circumstances

From: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_resetwal prints new OldestXID in wrong circumstances
Date: 2025-11-19 10:05:12
Message-ID: aR2WWN6fW/8BFOkx@ip-10-97-1-34.eu-west-3.compute.internal
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Hi,

On Wed, Nov 19, 2025 at 11:52:31AM +0200, Heikki Linnakangas wrote:
> Printing the new OldestXID value is incorrectly tied to whether the
> --next-transaction-id option is given, so this prints it, even though
> OldestXID is not being modified:

Nice catch!

> This seems to have been an oversight when the --oldest-transaction-id option
> was added (commit 74cf7d46a91d).

yeah.

> Before that, OldestXID was reset when the
> --next-transaction-id option was given.
>
> Fix attached. Barring objections, I will commit and backpatch this.

LGTM, thanks!

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Richard Guo 2025-11-19 10:07:26 Re: GROUP BY ROLLUP queries on views trigger full table scans (index usage not optimized)
Previous Message S, Naveen Krishna (Development Engineer 3) 2025-11-19 09:54:41 Re: [EXTERNAL] Re: BUG #19114: ORDER BY ASC is tampering result when calculating distance btw vectors