Re: allow running parts of src/tools/msvc/ under not Windows

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Julien Rouhaud <rjuju123(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: allow running parts of src/tools/msvc/ under not Windows
Date: 2020-02-20 14:31:32
Message-ID: 6076.1582209092@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> On 2020-02-13 16:36, Tom Lane wrote:
>> Yeah, I'm wondering exactly how this helps. IME the typical sort of
>> breakage is "the MSVC build doesn't know that file X needs to be
>> included when building Y". It seems like just building the project
>> files will teach one nothing about that type of omission.

> The main benefit is that if you make "blind" edits in the Perl files,
> you can verify them easily, first by seeing that the Perl code runs,
> second, depending on the circumstances, by diffing the created project
> files. Another is that if you do some nontrivial surgery in makefiles,
> you can check whether the Perl code can still process them. So the
> benefit is mainly that you can iterate faster when working on build
> system related things. You still need to do a full test on Windows at
> the conclusion, but then hopefully with a better chance of success.

I see. No objection then.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Anastasia Lubennikova 2020-02-20 15:38:22 Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index.
Previous Message Julien Rouhaud 2020-02-20 13:52:29 Re: Minor improvement to partition_bounds_copy()