Re: Minor improvement to partition_bounds_copy()

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Amit Langote <amitlangote09(at)gmail(dot)com>
Cc: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Minor improvement to partition_bounds_copy()
Date: 2020-02-20 13:52:29
Message-ID: 20200220135229.GA31174@nol
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Feb 20, 2020 at 09:38:26PM +0900, Amit Langote wrote:
> Fujita-san,
>
> On Thu, Feb 20, 2020 at 8:36 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> > partition_bounds_copy() sets the hash_part and natts variable in each
> > iteration of a loop to copy the datums in the datums array, which
> > would not be efficient. Attached is small patch for avoiding that.
>
> That looks good to me.

Looks good to me too!

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-02-20 14:31:32 Re: allow running parts of src/tools/msvc/ under not Windows
Previous Message David Steele 2020-02-20 13:37:15 Re: [Patch] Make pg_checksums skip foreign tablespace directories