Re: Increase pltcl test coverage

From: Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Karl Lehenbauer <karl(at)flightaware(dot)com>
Subject: Re: Increase pltcl test coverage
Date: 2017-01-09 21:45:57
Message-ID: 5fe0a8cd-4e1b-2bb2-5b96-53b800c49cc4@BlueTreble.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 1/9/17 3:12 PM, Jim Nasby wrote:
> I'm compiling 8.4 now, will see if I can duplicate.

Got a stack trace. The abort happens in TclObjLookupVar:

if (nsPtr->varResProc != NULL || iPtr->resolverPtr != NULL) {

nsPtr itself is NULL.

> * thread #1: tid = 0x0000, 0x000000010949bca8 libtcl8.4g.dylib`TclObjLookupVar(interp=0x00007fdc7b508ba0, part1Ptr=0x00007fdc7d009090, part2=0x0000000000000000, flags=5, msg="set", createPart1=1, createPart2=1, arrayPtrPtr=0x00007fff5712e3c0) + 440 at tclVar.c:400, stop reason = signal SIGSTOP
> * frame #0: 0x000000010949bca8 libtcl8.4g.dylib`TclObjLookupVar(interp=0x00007fdc7b508ba0, part1Ptr=0x00007fdc7d009090, part2=0x0000000000000000, flags=5, msg="set", createPart1=1, createPart2=1, arrayPtrPtr=0x00007fff5712e3c0) + 440 at tclVar.c:400
> frame #1: 0x000000010949d22e libtcl8.4g.dylib`Tcl_ObjSetVar2(interp=0x00007fdc7b508ba0, part1Ptr=0x00007fdc7d009090, part2Ptr=0x0000000000000000, newValuePtr=0x00007fdc7c00e800, flags=5) + 170 at tclVar.c:1517
> frame #2: 0x000000010941407a libtcl8.4g.dylib`Tcl_AddObjErrorInfo(interp=0x00007fdc7b508ba0, message="\n invoked from within\n\"__PLTcl_proc_16466 {quote foo bar}\"", length=-1) + 460 at tclBasic.c:6530
> frame #3: 0x0000000109411514 libtcl8.4g.dylib`Tcl_LogCommandInfo(interp=0x00007fdc7b508ba0, script="__PLTcl_proc_16466 {quote foo bar}", command="__PLTcl_proc_16466 {quote foo bar}", length=34) + 488 at tclBasic.c:3521
> frame #4: 0x00000001094112fa libtcl8.4g.dylib`Tcl_EvalObjv(interp=0x00007fdc7b508ba0, objc=2, objv=0x00007fff5712e6d0, flags=393216) + 740 at tclBasic.c:3428
> frame #5: 0x000000010941247d libtcl8.4g.dylib`Tcl_EvalObjEx(interp=0x00007fdc7b508ba0, objPtr=0x00007fdc7c001260, flags=393216) + 376 at tclBasic.c:5109
> frame #6: 0x00000001093efe24 pltcl.so`pltcl_func_handler + 660
> frame #7: 0x00000001093ef186 pltcl.so`pltcl_handler + 246
> frame #8: 0x0000000108c3ff91 postgres`ExecMakeFunctionResultNoSets + 209
> frame #9: 0x0000000108c3f42e postgres`ExecProject + 590
> frame #10: 0x0000000108c56153 postgres`ExecResult + 179
> frame #11: 0x0000000108c38bae postgres`ExecProcNode + 94
> frame #12: 0x0000000108c35010 postgres`standard_ExecutorRun + 288
> frame #13: 0x0000000108d5ab3f postgres`PortalRunSelect + 239
> frame #14: 0x0000000108d5a744 postgres`PortalRun + 500
> frame #15: 0x0000000108d58919 postgres`PostgresMain + 8745
> frame #16: 0x0000000108cec483 postgres`PostmasterMain + 7443
> frame #17: 0x0000000108c717ba postgres`main + 1562
> frame #18: 0x00007fff8dd765ad libdyld.dylib`start + 1

--
Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
Experts in Analytics, Data Architecture and PostgreSQL
Data in Trouble? Get it in Treble! http://BlueTreble.com
855-TREBLE2 (855-873-2532)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2017-01-09 22:09:15 Re: WIP: [[Parallel] Shared] Hash
Previous Message Jonathon Nelson 2017-01-09 21:27:56 Re: [PATCH] guc-ify the formerly hard-coded MAX_SEND_SIZE to max_wal_send