Re: Increase pltcl test coverage

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Karl Lehenbauer <karl(at)flightaware(dot)com>
Subject: Re: Increase pltcl test coverage
Date: 2017-01-09 22:23:06
Message-ID: 5403.1484000586@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com> writes:
> Got a stack trace. The abort happens in TclObjLookupVar:

Yeah, I found the problem: pltcl_returnnext calls pltcl_build_tuple_result
which may throw elog(ERROR), leaving the Tcl interpreter's state all
screwed up, so that later functions go south. It seems quite accidental
that this is only failing with 8.4. We need pltcl_returnnext to use a
subtransction, like the other pltcl statements that can call into generic
PG code. Working on a fix now.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2017-01-09 22:36:56 Re: PoC: Make it possible to disallow WHERE-less UPDATE and DELETE
Previous Message Thomas Munro 2017-01-09 22:09:15 Re: WIP: [[Parallel] Shared] Hash