Re: amcheck: Remove unused IndexCheckableCallback typedef

From: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
To: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: amcheck: Remove unused IndexCheckableCallback typedef
Date: 2025-07-04 08:25:26
Message-ID: 4CBF8299-22E1-4CF8-80B0-32EEF8223911@yandex-team.ru
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 4 Jul 2025, at 10:50, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>
> From the discussion in [1], it seems this typedef was originally used as
> a function argument in early versions of the patch. However,
> the argument was removed in v23, and the typedef was accidentally left behind.

Yes, your analysis is correct. We could make common checking function and argument was not needed.

>
> The attached patch removes this unused typedef to clean up the dead code.
> Thoughts?

Looks good to me. Thanks for fixing this!

Best regards, Andrey Borodin.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ilia Evdokimov 2025-07-04 08:30:53 Re: Add estimated hit ratio to Memoize in EXPLAIN to explain cost adjustment
Previous Message Álvaro Herrera 2025-07-04 08:10:32 Re: Inconsistent LSN format in pg_waldump output