Re: logical replication apply to run with sync commit off by default

From: Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Erik Rijkers <er(at)xs4all(dot)nl>
Subject: Re: logical replication apply to run with sync commit off by default
Date: 2017-03-24 14:49:24
Message-ID: 5bb7656d-3fcf-1574-2a62-cf86559da637@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 21/03/17 22:37, Petr Jelinek wrote:
> On 21/03/17 18:54, Robert Haas wrote:
>> On Mon, Mar 20, 2017 at 7:56 PM, Petr Jelinek
>> <petr(dot)jelinek(at)2ndquadrant(dot)com> wrote:
>>> On 18/03/17 13:31, Petr Jelinek wrote:
>>>> On 07/03/17 06:23, Petr Jelinek wrote:
>>>>> there has been discussion at the logical replication initial copy thread
>>>>> [1] about making apply work with sync commit off by default for
>>>>> performance reasons and adding option to change that per subscription.
>>>>>
>>>>> Here I propose patch to implement this - it adds boolean column
>>>>> subssynccommit to pg_subscription catalog which decides if
>>>>> synchronous_commit should be off or local for apply. And it adds
>>>>> SYNCHRONOUS_COMMIT = boolean to the list of WITH options for CREATE and
>>>>> ALTER SUBSCRIPTION. When nothing is specified it will set it to false.
>>>>>
>>>>> The patch is built on top of copy patch currently as there are conflicts
>>>>> between the two and this helps a bit with testing of copy patch.
>>>>>
>>>>> [1]
>>>>> https://www.postgresql.org/message-id/CA+TgmoY7Lk2YKArcp4O=Qu=xOoR8j71MAd1OTEojAWmujE3k0w@mail.gmail.com
>>>>>
>>>>
>>>> I rebased this patch against recent changes and the latest version of
>>>> copy patch.
>>>

Rebase after table copy patch got committed.

--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
0001-Add-option-to-modify-sync-commit-per-subscription.patch text/x-patch 20.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Steele 2017-03-24 14:50:33 Re: Index usage for elem-contained-by-const-range clauses
Previous Message Petr Jelinek 2017-03-24 14:48:06 Re: Logical replication origin tracking fix