| From: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com> |
| Subject: | Re: Logical replication origin tracking fix |
| Date: | 2017-03-24 14:48:06 |
| Message-ID: | b623985f-6255-13a6-005b-8af5fa03dba5@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10/03/17 05:59, Petr Jelinek wrote:
> Hi,
>
> while discussing with Craig issues around restarting logical replication
> stream related to the patch he posted [1], I realized that we track
> wrong origin LSN in the logical replication apply.
>
> We currently track commit_lsn which is *start* of commit record, what we
> need to track is end_lsn which is *end* of commit record otherwise we
> might request transaction that was already replayed if the subscription
> instance has crashed right after commit.
>
> Attached patch fixes that.
>
Rebase after table copy patch got committed.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-remote-position-tracking-in-logical-replication.patch | text/x-patch | 1.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Petr Jelinek | 2017-03-24 14:49:24 | Re: logical replication apply to run with sync commit off by default |
| Previous Message | Petr Jelinek | 2017-03-24 14:45:50 | Fix slot name change handling for subscriptions |