| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Christoph Berg <myon(at)debian(dot)org> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [HACKERS] Time to change pg_regress diffs to unified by default? |
| Date: | 2019-02-15 14:16:00 |
| Message-ID: | 5b72cf02-61e1-0219-cc91-c6b4e4144c8b@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-01-03 11:20, Daniel Gustafsson wrote:
>> On 3 Jan 2019, at 10:39, Christoph Berg <myon(at)debian(dot)org> wrote:
>>
>> Re: Peter Eisentraut 2019-01-02 <70440c81-37bb-76dd-e48b-b5a9550d5613(at)2ndquadrant(dot)com>
>
>>> While we're considering the pg_regress output, what do you think about
>>> replacing the ======... separator with a standard diff separator like
>>> "diff %s %s %s\n". This would make the file behave more like a proper
>>> diff file, for use with other tools. And it shows the diff options
>>> used, for clarity. See attached patch.
>>
>> It will especially say which _alternate.out file was used, which seems
>> like a big win. So +1.
>
> That has bitten more times than I’d like to admit, so definately +1 on being
> explicit about that.
committed
(This might be one of those rare times where one hopes for a buildfarm
failure for verification. :-) )
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Darafei Praliaskouski | 2019-02-15 14:19:06 | Re: [PATCH][PROPOSAL] Add enum releation option type |
| Previous Message | Peter Eisentraut | 2019-02-15 14:13:48 | Re: Reporting script runtimes in pg_regress |