Re: [HACKERS] Time to change pg_regress diffs to unified by default?

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Christoph Berg <myon(at)debian(dot)org>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [HACKERS] Time to change pg_regress diffs to unified by default?
Date: 2019-01-03 10:20:29
Message-ID: FADC3FB8-D1D7-478B-BA79-5B3EAD86B1F7@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 3 Jan 2019, at 10:39, Christoph Berg <myon(at)debian(dot)org> wrote:
>
> Re: Peter Eisentraut 2019-01-02 <70440c81-37bb-76dd-e48b-b5a9550d5613(at)2ndquadrant(dot)com>

>> While we're considering the pg_regress output, what do you think about
>> replacing the ======... separator with a standard diff separator like
>> "diff %s %s %s\n". This would make the file behave more like a proper
>> diff file, for use with other tools. And it shows the diff options
>> used, for clarity. See attached patch.
>
> It will especially say which _alternate.out file was used, which seems
> like a big win. So +1.

That has bitten more times than I’d like to admit, so definately +1 on being
explicit about that.

cheers ./daniel

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2019-01-03 11:02:47 Re: [HACKERS] Time to change pg_regress diffs to unified by default?
Previous Message Christoph Berg 2019-01-03 09:39:17 Re: [HACKERS] Time to change pg_regress diffs to unified by default?