| From: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Stephen Frost <sfrost(at)snowman(dot)net>, Maksim Milyutin <milyutinma(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Add support for tuple routing to foreign partitions |
| Date: | 2018-03-30 12:57:29 |
| Message-ID: | 5ABE3439.7080607@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
(2018/03/20 21:31), Alvaro Herrera wrote:
> Amit Langote wrote:
>
>> 2. If I understand the description you provided in [1] correctly, the
>> point of having ri_PartitionIsValid and ExecInitExtraPartitionInfo() is to
>> avoid possibly-redundantly performing following two steps in
>> ExecSetupPartitionTupleRouting() for *reused* partition ResultRelInfos
>> that may not be used for tuple routing after all:
>>
>> - create the parent_child_tupconv_maps[] entry for it
>> - perform FDW tuple routing initialization.
>>
>> If that's true, the following comment could be expanded just a little bit
>> to make that clearer:
>>
>> /*
>> * ExecInitPartitionExtraInfo
>> * Do the remaining initialization work for the given partition
>
> Yeah, I think the comments on why this is a separate step should be more
> extensive. Probably add something to ExecInitPartitionInfo too.
Done. Please see the reply to Amit that I sent just now.
Thank you for the review!
Best regards,
Etsuro Fujita
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2018-03-30 13:00:14 | Re: [HACKERS] path toward faster partition pruning |
| Previous Message | Etsuro Fujita | 2018-03-30 12:56:59 | Re: [HACKERS] Add support for tuple routing to foreign partitions |