| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Amit Langote <amitlangote09(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Beena Emerson <memissemerson(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] path toward faster partition pruning |
| Date: | 2018-03-30 13:00:14 |
| Message-ID: | CAKJS1f-fX4=zcYAxr9-ONez9rq2UrjiWauBY_71ug+3OcD-8cw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 31 March 2018 at 01:18, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> wrote:
> I've noticed that there are no outfuncs or readfuncs for all the new
> Step types you've added.
>
> Also, the copy func does not properly copy the step_id in the base
> node type. This will remain at 0 after a copyObject()
I've attached a quickly put together fix for this. I'm not quite sure
what the done thing is to copy/read/write nodes which inherit fields
from other nodes, so what I've done in the attached might not be
correct. However, I see _copyValue() does what I've done, so perhaps
its fine, or that may just be more of a special case.
I also manually removed some hunks from the diff, so hopefully, it
still works correctly.
Attaching it as it may save you some time from doing it yourself.
Please check it though.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| copy_read_write_func_fixes.patch | application/octet-stream | 3.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-03-30 13:02:07 | Re: Typo in xlog.c |
| Previous Message | Etsuro Fujita | 2018-03-30 12:57:29 | Re: [HACKERS] Add support for tuple routing to foreign partitions |